seamus

commit cdc41232adc8ae2c3d63cb0abe39cefcca31dc13

Author: Pedro Lucas Porcellis <porcellis@eletrotupi.com>

seamus/ui: add unused param casts and scroll boundary guard

 src/seamus.c | 4 ++--
 src/ui.c | 19 +++++++++++++++++--


diff --git a/src/seamus.c b/src/seamus.c
index b4fb8a9591d00ccee27be6d1288af9e57112859c..53c2b29ab37dabb5294ddfedf7d02bb4a6218685 100755
--- a/src/seamus.c
+++ b/src/seamus.c
@@ -67,6 +67,8 @@
 int
 main(int argc, char *argv[])
 {
+	(void)argc;
+	(void)argv;
 	struct seamus_frontend seamus = {0};
 
 	int r = seamus_init(&seamus);
@@ -89,8 +91,6 @@ 	tickit_start(&seamus);
 
 exit_tickit:
 	tickit_finish(&seamus);
-
-exit_mpd:
 	seamus_finish(&seamus);
 
 	return 0;




diff --git a/src/ui.c b/src/ui.c
index cecf69585a13b1e5e2656ff16713d29cf4bf2586..23396516a636a5f6d05a707b647179d974c04cf4 100644
--- a/src/ui.c
+++ b/src/ui.c
@@ -79,6 +79,8 @@
 static int
 on_key_event(TickitTerm *tt, TickitEventFlags flags, void *_info, void *data)
 {
+	(void)tt;
+	(void)flags;
 	TickitKeyEventInfo *info = _info;
 
 	struct seamus_frontend *seamus = (struct seamus_frontend*) data;
@@ -133,6 +135,10 @@ update_scroll_position(struct seamus_frontend *seamus, int direction)
 {
 	log_info("Current position %d, direction: %d, length: %d", seamus->scroll_position, direction, seamus->status->length);
 
+	if (seamus->status->length <= 0) {
+		return 0;
+	}
+
 	if (seamus->scroll_position == 0 && direction == -1) {
 		return 0;
 	}
@@ -154,6 +160,8 @@
 static int
 update_status(Tickit *t, TickitEventFlags flags, void *_info, void *data)
 {
+	(void)flags;
+	(void)_info;
 	struct seamus_frontend *seamus = (struct seamus_frontend*) data;
 
 	tickit_window_expose(seamus->status_window, NULL);
@@ -165,6 +173,8 @@
 static int
 update_main_window(Tickit *t, TickitEventFlags flags, void *_info, void *data)
 {
+	(void)flags;
+	(void)_info;
 	struct seamus_frontend *seamus = (struct seamus_frontend*) data;
 
 	tickit_window_expose(seamus->main_window, NULL);
@@ -176,9 +186,10 @@
 static int
 render_root(TickitWindow *win, TickitEventFlags flags, void *_info, void *data)
 {
+	(void)flags;
+	(void)data;
 	TickitExposeEventInfo *info = _info;
 	TickitRenderBuffer *render_buffer = info->rb;
-	struct seamus_frontend *seamus = (struct seamus_frontend*) data;
 
 	int right = tickit_window_cols(win) - 1;
 	int bottom = tickit_window_lines(win) - 1;
@@ -193,6 +204,8 @@
 static int
 render_status_window(TickitWindow *win, TickitEventFlags flags, void *_info, void *data)
 {
+	(void)win;
+	(void)flags;
 	TickitExposeEventInfo *info = _info;
 	TickitRenderBuffer *render_buffer = info->rb;
 	struct seamus_frontend *seamus = (struct seamus_frontend*) data;
@@ -240,6 +253,8 @@
 static int
 render_main_window(TickitWindow *win, TickitEventFlags flags, void *_info, void *data)
 {
+	(void)win;
+	(void)flags;
 	log_info("Rendering the main window");
 	TickitExposeEventInfo *info = _info;
 	TickitRenderBuffer *render_buffer = info->rb;
@@ -291,7 +306,7 @@ static int
 render_queue(struct seamus_frontend *seamus, TickitRenderBuffer *render_buffer)
 {
 	log_info("Rendering the queue");
-	for (size_t i = 0; i < seamus->queue_size; ++i) {
+	for (int i = 0; i < seamus->queue_size; ++i) {
 		struct seamus_song *song = &seamus->queue[i];
 
 		if (song == NULL) {