cirandas.net

ref: master

test/api/comments_test.rb


  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
require_relative 'test_helper'

class CommentsTest < ActiveSupport::TestCase

  def setup
    @local_person = fast_create(Person)
    create_and_activate_user
  end

  should 'logged user not list comments if user has no permission to view the source article' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing", :published => false)
    assert !article.published?

    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    assert_equal 403, last_response.status
  end

  should 'logged user not return comment if user has no permission to view the source article' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing", :published => false)
    comment = article.comments.create!(:body => "another comment", :author => @local_person)
    assert !article.published?

    get "/api/v1/articles/#{article.id}/comments/#{comment.id}?#{params.to_query}"
    assert_equal 403, last_response.status
  end

  should 'logged user not comment an article if user has no permission to view it' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing", :published => false)
    assert !article.published?

    post "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    assert_equal 403, last_response.status
  end

  should 'logged user return comments of an article' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    article.comments.create!(:body => "some comment", :author => @local_person)
    article.comments.create!(:body => "another comment", :author => @local_person)

    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_equal 2, json.length
  end

  should 'logged user return comment of an article' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    comment = article.comments.create!(:body => "another comment", :author => @local_person)

    get "/api/v1/articles/#{article.id}/comments/#{comment.id}?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_equal comment.id, json['id']
  end

  should 'logged user comment an article' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    body = 'My comment'
    params.merge!({:body => body})

    post "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 201, last_response.status
    assert_equal body, json['body']
  end

  should 'not create comment when an article does not accept comments' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing", accept_comments: false)
    body = 'My comment'
    params.merge!({:body => body})
    post "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 403, last_response.status
  end

  should 'logged user not comment an archived article' do
    login_api
    article = fast_create(Article, :profile_id => user.person.id, :name => "Some thing", :archived => true)
    body = 'My comment'
    params.merge!({:body => body})

    post "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    assert_equal 400, last_response.status
  end

  should 'logged user comment creation define the source' do
    login_api
    amount = Comment.count
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    body = 'My comment'
    params.merge!({:body => body})

    post "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    assert_equal amount + 1, Comment.count
    comment = Comment.last
    assert_not_nil comment.source
  end

  should 'call plugin hotspot to filter unavailable comments' do
    class Plugin1 < Noosfero::Plugin
      def unavailable_comments(scope)
        scope.where(:user_agent => 'Jack')
      end
    end
    Noosfero::Plugin.stubs(:all).returns([Plugin1.name])
    Environment.default.enable_plugin(Plugin1)

    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    c1 = fast_create(Comment, source_id: article.id, body: "comment 1")
    c2 = fast_create(Comment, source_id: article.id, body: "comment 2", :user_agent => 'Jack')

    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal ["comment 2"], json.map {|c| c["body"]}
  end

  should 'anonymous do not return comments marked as spam' do
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    c1 = fast_create(Comment, source_id: article.id, body: "comment 1", spam: true)
    c2 = fast_create(Comment, source_id: article.id, body: "comment 2")
    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal ["comment 2"], json.map {|c| c["body"]}
  end

  should 'not list comments if anonymous has no permission to view the source article' do
    article = fast_create(Article, :profile_id => person.id, :name => "Some thing", :published => false)
    assert !article.published?

    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    assert_equal 403, last_response.status
  end

  should 'return comments of an article for anonymous' do
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    article.comments.create!(:body => "some comment", :author => @local_person)
    article.comments.create!(:body => "another comment", :author => @local_person)

    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_equal 2, json.length
  end

  should 'return comment of an article for anonymous' do
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    comment = article.comments.create!(:body => "another comment", :author => @local_person)

    get "/api/v1/articles/#{article.id}/comments/#{comment.id}?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_equal comment.id, json['id']
  end

  should 'anonymous user not comment an article' do
    article = fast_create(Article, :profile_id => person.id, :name => "Some thing")
    body = 'My comment'
    name = "John Doe"
    email = "JohnDoe@gmail.com"
    params.merge!({:body => body, name: name, email: email})

    post "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 401, last_response.status
  end

  should 'logged user paginate comments' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    5.times { article.comments.create!(:body => "some comment", :author => @local_person) }
    params[:per_page] = 3

    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_equal 3, json.length
  end

  should 'logged user return only root comments' do
    login_api
    article = fast_create(Article, :profile_id => @local_person.id, :name => "Some thing")
    comment1 = article.comments.create!(:body => "some comment", :author => @local_person)
    comment2 = article.comments.create!(:body => "another comment", :author => @local_person, :reply_of_id => comment1.id)
    params[:without_reply] = true

    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_equal [comment1.id], json.map { |c| c['id'] }
  end

  should 'delete comment successfully' do
    login_api
    article = fast_create(Article, profile_id: person.id, name: "Some thing")
    comment = article.comments.create!(body: "some comment", author: person)
    delete "api/v1/articles/#{article.id}/comments/#{comment.id}?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_equal comment.id, json['id']
    assert_not_includes article.comments, comment
  end

  should 'not delete a comment when user is not logged' do
    article = fast_create(Article, profile_id: person.id, name: "Some thing")
    comment = article.comments.create!(body: "some comment", author: person)
    delete "api/v1/articles/#{article.id}/comments/#{comment.id}?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 403, last_response.status
    assert_includes article.comments, comment
  end

  should 'not delete a comment when user does not have permission' do
    login_api
    article = fast_create(Article, profile_id: @local_person.id, name: "Some thing")
    comment = article.comments.create!(body: "some comment", author: @local_person)
    delete "api/v1/articles/#{article.id}/comments/#{comment.id}?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 403, last_response.status
    assert_includes article.comments, comment
  end

  should 'return not found when delete a inexistent comment' do
    article = fast_create(Article, profile_id: person.id, name: "Some thing")
    comment = article.comments.create!(body: "some comment", author: person)
    delete "api/v1/articles/#{article.id}/comments/0?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 404, last_response.status
    assert_includes article.comments, comment
  end

  should 'return error when failed to delete comment' do
    login_api
    article = fast_create(Article, profile_id: person.id, name: "Some thing")
    comment = article.comments.create!(body: "some comment", author: person)
    Comment.any_instance.expects(:destroy).raises(StandardError)
    delete "api/v1/articles/#{article.id}/comments/#{comment.id}?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 500, last_response.status
    assert_includes article.comments, comment
  end

  should 'list allow_destroy permission when get your own comment' do
    login_api
    article = fast_create(Article, :profile_id => @person.id, :name => "Some thing")
    article.comments.create!(:body => "some comment", :author => @person)
    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_includes json[0]["permissions"], 'allow_destroy'
  end

  should 'anonymous not allowed to destroy comments' do
    article = fast_create(Article, :profile_id => @person.id, :name => "Some thing")
    article.comments.create!(:body => "some comment", :author => @person)
    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_not_includes json[0]["permissions"], 'allow_destroy'
  end

  should 'unprivileged user not be allowed to destroy other people comments' do
    article = fast_create(Article, profile_id: @local_person.id, name: "Some thing")
    comment = article.comments.create!(body: "some comment", author: @local_person)
    login_api
    get "/api/v1/articles/#{article.id}/comments?#{params.to_query}"
    json = JSON.parse(last_response.body)
    assert_equal 200, last_response.status
    assert_not_includes json[0]["permissions"], 'allow_destroy'
  end

end