Author: Lars Hjemli <hjemli@gmail.com>
Don't show new and old filemode for added/removed files It gives us no extra info whatsoever to show "----------" for either new or old mode, it's just noise (especially since we now show the "old" filemode for deleted files) Signed-off-by: Lars Hjemli <hjemli@gmail.com>
ui-commit.c | 11 +++++++++--
diff --git a/ui-commit.c b/ui-commit.c index c5ee8e70490e3e1c963c903b3e171ed131eb3775..b49b2e9f187724adf04b017e9d3545d6a6b3dcfb 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -46,8 +46,15 @@ } html("<tr>"); htmlf("<td class='mode'>"); - html_filemode(pair->two->mode); - if (pair->one->mode != pair->two->mode) { + if (is_null_sha1(pair->two->sha1)) { + html_filemode(pair->one->mode); + } else { + html_filemode(pair->two->mode); + } + + if (pair->one->mode != pair->two->mode && + !is_null_sha1(pair->one->sha1) && + !is_null_sha1(pair->two->sha1)) { html("<span class='modechange'>["); html_filemode(pair->one->mode); html("]</span>");