Author: Lars Hjemli <hjemli@gmail.com>
Simplify ui-commit.c Replace the call to lookup_commit() with a call to lookup_commit_reference, since it handles reading and parsing of the commit object internally. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
ui-commit.c | 17 +----------------
diff --git a/ui-commit.c b/ui-commit.c index e9de411e98bbfcf3c0b0cb6a1ccba99a4ed61990..b441e143b3ac1daec60b3b416b14610aef82785e 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -13,9 +13,6 @@ { struct commit *commit; struct commitinfo *info; struct commit_list *p; - unsigned long size; - char type[20]; - char *buf; unsigned char sha1[20]; @@ -24,21 +21,9 @@ cgit_print_error(fmt("Bad object id: %s", hex)); return; } - buf = read_sha1_file(sha1, type, &size); - if (!buf) { - cgit_print_error(fmt("Bad object reference: %s", hex)); - return; - } - - commit = lookup_commit(sha1); + commit = lookup_commit_reference(sha1); if (!commit) { cgit_print_error(fmt("Bad commit reference: %s", hex)); - return; - } - - commit->buffer = buf; - if (parse_commit_buffer(commit, buf, size)) { - cgit_print_error(fmt("Malformed commit buffer: %s", hex)); return; }