Author: Christian Hesse <mail@eworm.de>
ui-ssdiff: fix resource leak: free allocation from cgit_fileurl Coverity-id: 13929 Signed-off-by: Christian Hesse <mail@eworm.de>
ui-ssdiff.c | 8 ++++++--
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 2146c7120d7a38a7a87b64f1e8183c6340406dce..d183d40501a2393a1db0c1a565c759bfdbc3ba06 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -230,11 +230,13 @@ if (old_line_no > 0) {
struct diff_filespec *old_file = cgit_get_current_old_file();
char *lineno_str = fmt("n%d", old_line_no);
char *id_str = fmt("id=%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str);
+ char *fileurl = cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str);
html("<td class='lineno'><a href='");
- html(cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str));
+ html(fileurl);
htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1);
html("</td>");
htmlf("<td class='%s'>", class);
+ free(fileurl);
} else if (old_line)
htmlf("<td class='lineno'></td><td class='%s'>", class);
else
@@ -251,11 +253,13 @@ if (new_line_no > 0) {
struct diff_filespec *new_file = cgit_get_current_new_file();
char *lineno_str = fmt("n%d", new_line_no);
char *id_str = fmt("id=%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str);
+ char *fileurl = cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str);
html("<td class='lineno'><a href='");
- html(cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str));
+ html(fileurl);
htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1);
html("</td>");
htmlf("<td class='%s'>", class);
+ free(fileurl);
} else if (new_line)
htmlf("<td class='lineno'></td><td class='%s'>", class);
else