Author: Lars Hjemli <hjemli@gmail.com>
Do not alter incoming sha1 when handling the download refs. The code used to overwrite the const sha1 parameter just to avoid declaring an extra variable. Fix it. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
ui-summary.c | 7 +++++--
diff --git a/ui-summary.c b/ui-summary.c index 3410e1acff9ed4b155865ce3ea7fbc9221af00c1..b99ea9840e6c2cece046a336f0f077d073fb9122 100644 --- a/ui-summary.c +++ b/ui-summary.c @@ -130,6 +130,7 @@ struct tag *tag; struct taginfo *info; struct object *obj; char buf[256], *url; + unsigned char fileid[20]; if (prefixcmp(refname, "refs/archives")) return 0; @@ -141,9 +142,11 @@ if (obj->type == OBJ_TAG) { tag = lookup_tag(sha1); if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) return 0; - hashcpy(sha1, tag->tagged->sha1); + hashcpy(fileid, tag->tagged->sha1); } else if (obj->type != OBJ_BLOB) { return 0; + } else { + hashcpy(fileid, sha1); } if (!header) { html("<table>"); @@ -152,7 +155,7 @@ header = 1; } html("<tr><td>"); url = cgit_pageurl(cgit_query_repo, "blob", - fmt("id=%s&path=%s", sha1_to_hex(sha1), + fmt("id=%s&path=%s", sha1_to_hex(fileid), buf)); html_link_open(url, NULL, NULL); html_txt(buf);