Author: Lars Hjemli <hjemli@gmail.com>
cgit_parse_commit(): Add missing call to xstrdup() It's rather silly to point into random memory-locations. Also, remove a call to strdup() used on a literal char *. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
parsing.c | 4 ++--
diff --git a/parsing.c b/parsing.c index ddbafd5df4cb5221da407ffd9c566afb0c69f8d2..30e7648958789fb72930c405d1ba8d8c5a382f27 100644 --- a/parsing.c +++ b/parsing.c @@ -242,14 +242,14 @@ t = strchr(p, '\n'); if (t) { if (*t == '\0') - ret->subject = strdup("** empty **"); + ret->subject = "** empty **"; else ret->subject = substr(p, t); p = t + 1; while (*p == '\n') p = strchr(p, '\n') + 1; - ret->msg = p; + ret->msg = xstrdup(p); } else ret->subject = substr(p, p+strlen(p));