cgit

commit c366bd6fa88fb7dbe1e42c84d56e2bda0b1682c5

Author: William Bell <william.bell@frog.za.net>

ui: Remember to print ampersand as proper html entities.

 ui-repolist.c | 2 +-
 ui-shared.c | 14 +++++++-------


diff --git a/ui-repolist.c b/ui-repolist.c
index c774632622fcaccf9cb62364d3888bbf1c544b1f..36c067a3cb22643c6dca3187c6f84c0a73fda53e 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -104,7 +104,7 @@ void print_sort_header(const char *title, const char *sort)
 {
 	htmlf("<th class='left'><a href='%s?s=%s", cgit_rooturl(), sort);
 	if (ctx.qry.search) {
-		html("&q=");
+		html("&amp;q=");
 		html_url_arg(ctx.qry.search);
 	}
 	htmlf("'>%s</a></th>", title);




diff --git a/ui-shared.c b/ui-shared.c
index 43166af4d568125306ff3f88d2f6f97c54d2405e..d9d5da74ac14ddb2e01772571e461dfae36c0844 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -83,7 +83,7 @@ 		delim = "?";
 	} else {
 		tmp = fmt("?url=%s/%s/%s", reponame, pagename,
 			  (filename ? filename : ""));
-		delim = "&";
+		delim = "&amp;";
 	}
 	if (query)
 		tmp = fmt("%s%s%s", tmp, delim, query);
@@ -146,19 +146,19 @@ 		html(ctx.cfg.script_name);
 
 	if (page) {
 		htmlf("?p=%s", page);
-		delim = "&";
+		delim = "&amp;";
 	}
 	if (search) {
 		html(delim);
 		html("q=");
 		html_attr(search);
-		delim = "&";
+		delim = "&amp;";
 	}
 	if (sort) {
 		html(delim);
 		html("s=");
 		html_attr(sort);
-		delim = "&";
+		delim = "&amp;";
 	}
 	if (ofs) {
 		html(delim);
@@ -298,13 +298,13 @@ 	if (rev && ctx.qry.head && strcmp(rev, ctx.qry.head)) {
 		html(delim);
 		html("id=");
 		html_url_arg(rev);
-		delim = "&";
+		delim = "&amp;";
 	}
 	if (grep && pattern) {
 		html(delim);
 		html("qt=");
 		html_url_arg(grep);
-		delim = "&";
+		delim = "&amp;";
 		html(delim);
 		html("q=");
 		html_url_arg(pattern);
@@ -313,7 +313,7 @@ 	if (ofs > 0) {
 		html(delim);
 		html("ofs=");
 		htmlf("%d", ofs);
-		delim = "&";
+		delim = "&amp;";
 	}
 	if (showmsg) {
 		html(delim);