Author: Mark Lodato <lodatom@gmail.com>
use __attribute__ to catch printf format mistakes Use "__attribute__((format (printf,N,M)))", as is done in git, do catch mistakes in printf-style format strings. Signed-off-by: Mark Lodato <lodatom@gmail.com>
cache.h | 1 + cgit.h | 1 + html.h | 3 +++
diff --git a/cache.h b/cache.h index ac9276b5c43a410147bb63fa27565fc79d35e3f6..5cfdb4f37a2a82f5d83f073628d4d3803c97a551 100644 --- a/cache.h +++ b/cache.h @@ -30,6 +30,7 @@ /* List info about all cache entries on stdout */ extern int cache_ls(const char *path); /* Print a message to stdout */ +__attribute__((format (printf,1,2))) extern void cache_log(const char *format, ...); extern unsigned long hash_str(const char *str); diff --git a/cgit.h b/cgit.h index 4090cd4f2fe114d6a70f9d138d9b67b3ad861d39..8f8428196ac2fe05e8141e0c893cc29ad362c18d 100644 --- a/cgit.h +++ b/cgit.h @@ -293,6 +293,7 @@ filepair_fn fn, const char *prefix, int ignorews); extern void cgit_diff_commit(struct commit *commit, filepair_fn fn); +__attribute__((format (printf,1,2))) extern char *fmt(const char *format,...); extern struct commitinfo *cgit_parse_commit(struct commit *commit); diff --git a/html.h b/html.h index 16d55ec9a29449f518d6df6ddccc8cd9da55bbd8..1135fb8928c4581bab2e2194fec1911751d5bc6d 100644 --- a/html.h +++ b/html.h @@ -5,7 +5,10 @@ extern int htmlfd; extern void html_raw(const char *txt, size_t size); extern void html(const char *txt); + +__attribute__((format (printf,1,2))) extern void htmlf(const char *format,...); + extern void html_status(int code, const char *msg, int more_headers); extern void html_txt(const char *txt); extern void html_ntxt(int len, const char *txt);