Author: Peter Colberg <peter@colberg.org>
ui-repolist: return HTTP 404 if no repositories found Return HTTP status code 404 Not found when querying a non-existent repository, which signals to search engines that a repository no longer exists. Further, some webservers such as nginx permit logging requests to different files depending on the HTTP code. Signed-off-by: Peter Colberg <peter@colberg.org>
ui-repolist.c | 20 +++++++++++++++++---
diff --git a/ui-repolist.c b/ui-repolist.c index 4912fa55bd5628791f6bc4685f17f4219cc264bf..6010a39329b00b7f277ec293eeaa897c8b283297 100644 --- a/ui-repolist.c +++ b/ui-repolist.c @@ -115,6 +115,17 @@ return 0; return 1; } +static int any_repos_visible(void) +{ + int i; + + for (i = 0; i < cgit_repolist.count; i++) { + if (is_visible(&cgit_repolist.repos[i])) + return 1; + } + return 0; +} + static void print_sort_header(const char *title, const char *sort) { char *currenturl = cgit_currenturl(); @@ -266,6 +277,11 @@ char *last_section = NULL; char *section; int sorted = 0; + if (!any_repos_visible()) { + cgit_print_error_page(404, "Not found", "No repositories found"); + return; + } + if (ctx.cfg.enable_index_links) ++columns; if (ctx.cfg.enable_index_owner) @@ -347,9 +363,7 @@ } html("</tr>\n"); } html("</table>"); - if (!hits) - cgit_print_error("No repositories found"); - else if (hits > ctx.cfg.max_repo_count) + if (hits > ctx.cfg.max_repo_count) print_pager(hits, ctx.cfg.max_repo_count, ctx.qry.search, ctx.qry.sort); cgit_print_docend(); }