Author: Rys Sommefeldt <rys@pixeltards.com>
Close fd on error in readfile() Signed-off-by: Lars Hjemli <hjemli@gmail.com>
shared.c | 9 +++++++--
diff --git a/shared.c b/shared.c index d7b2d5a9efe777acc8140ae9401b9c9d17a5fd79..a27ab30716f276e4f6644e11734b19bc7cff1d5c 100644 --- a/shared.c +++ b/shared.c @@ -406,12 +406,17 @@ fd = open(path, O_RDONLY); if (fd == -1) return errno; - if (fstat(fd, &st)) + if (fstat(fd, &st)) { + close(fd); return errno; - if (!S_ISREG(st.st_mode)) + } + if (!S_ISREG(st.st_mode)) { + close(fd); return EISDIR; + } *buf = xmalloc(st.st_size + 1); *size = read_in_full(fd, *buf, st.st_size); (*buf)[*size] = '\0'; + close(fd); return (*size == st.st_size ? 0 : errno); }