Author: Christian Hesse <mail@eworm.de>
ui-shared: fix resource leak: free allocation from cgit_currenturl Coverity-id: 13927 Signed-off-by: Christian Hesse <mail@eworm.de>
ui-shared.c | 11 ++++++++---
diff --git a/ui-shared.c b/ui-shared.c index b7396756dfe1416e25d77776fac53259b34a365d..f6d38deb620de372456ea11d89eecfa6aa247f45 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -157,8 +157,11 @@ char *delim = "?"; if (always_root || page) html_attr(cgit_rooturl()); - else - html_attr(cgit_currenturl()); + else { + char *currenturl = cgit_currenturl(); + html_attr(currenturl); + free(currenturl); + } if (page) { htmlf("?p=%s", page); @@ -1020,19 +1023,21 @@ html("'/>\n"); html("<input type='submit' value='search'/>\n"); html("</form>\n"); } else if (ctx.env.authenticated) { + char *currenturl = cgit_currenturl(); site_link(NULL, "index", NULL, hc("repolist"), NULL, NULL, 0, 1); if (ctx.cfg.root_readme) site_link("about", "about", NULL, hc("about"), NULL, NULL, 0, 1); html("</td><td class='form'>"); html("<form method='get' action='"); - html_attr(cgit_currenturl()); + html_attr(currenturl); html("'>\n"); html("<input type='text' name='q' size='10' value='"); html_attr(ctx.qry.search); html("'/>\n"); html("<input type='submit' value='search'/>\n"); html("</form>"); + free(currenturl); } html("</td></tr></table>\n"); if (ctx.env.authenticated && ctx.qry.vpath) {