Author: Eric Wong <normalperson@yhbt.net>
ui-ssdiff.c: correct length check for LCS table Each individual string may be too long for its respective dimension of the LCS table. Signed-off-by: Eric Wong <normalperson@yhbt.net>
ui-ssdiff.c | 6 ++----
diff --git a/ui-ssdiff.c b/ui-ssdiff.c index 9fb5b1139af12c05d9817d9fcef884b843d928ca..45770b1a547fe773dc959a2acc49eebcef74a7f1 100644 --- a/ui-ssdiff.c +++ b/ui-ssdiff.c @@ -42,14 +42,12 @@ { int i, j, ri; int m = strlen(A); int n = strlen(B); - int tmp1, tmp2, length; + int tmp1, tmp2; int lcs_length; char *result; - length = (m + 1) * (n + 1); - // We bail if the lines are too long - if (length > MAX_SSDIFF_SIZE) + if (m >= MAX_SSDIFF_M || n >= MAX_SSDIFF_N) return NULL; create_or_reset_lcs_table();